Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike for parallel relaying between multiple channels #692

Merged
merged 16 commits into from
Mar 3, 2021

Conversation

romac
Copy link
Member

@romac romac commented Feb 19, 2021

Closes: #XXX

Description


For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@codecov-io
Copy link

codecov-io commented Feb 25, 2021

Codecov Report

Merging #692 (317f3d7) into master (b1b37f5) will increase coverage by 30.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    informalsystems/hermes#692      +/-   ##
=========================================
+ Coverage    13.6%   43.8%   +30.1%     
=========================================
  Files          69     154      +85     
  Lines        3752   10122    +6370     
  Branches     1374       0    -1374     
=========================================
+ Hits          513    4438    +3925     
- Misses       2618    5684    +3066     
+ Partials      621       0     -621     
Impacted Files Coverage Δ
modules/src/address.rs 100.0% <ø> (ø)
...application/ics20_fungible_token_transfer/error.rs 0.0% <ø> (ø)
...ion/ics20_fungible_token_transfer/msgs/transfer.rs 0.0% <ø> (ø)
modules/src/events.rs 0.0% <ø> (ø)
modules/src/handler.rs 100.0% <ø> (ø)
modules/src/ics02_client/client_def.rs 47.7% <ø> (ø)
modules/src/ics02_client/client_type.rs 79.1% <ø> (+31.5%) ⬆️
modules/src/ics02_client/context.rs 100.0% <ø> (ø)
modules/src/ics02_client/error.rs 100.0% <ø> (ø)
modules/src/ics02_client/events.rs 15.7% <ø> (+15.7%) ⬆️
... and 257 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51386f9...317f3d7. Read the comment docs.

@romac romac marked this pull request as ready for review February 26, 2021 17:14
modules/src/ics04_channel/events.rs Show resolved Hide resolved
relayer-cli/src/commands/start_multi.rs Outdated Show resolved Hide resolved
relayer-cli/src/commands/start_multi.rs Outdated Show resolved Hide resolved
relayer-cli/src/commands/start_multi.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@ancazamfir ancazamfir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks amazing! I ran it with three different channels and all looks good. Also reviewed the code, I think we should merge this asap, can't wait to have this in master :)
Thanks Romain!

relayer/src/supervisor.rs Outdated Show resolved Hide resolved
@romac romac merged commit 5af19fc into master Mar 3, 2021
@romac romac deleted the romac/multi-channel-spike branch March 3, 2021 12:32
@romac romac mentioned this pull request Apr 6, 2021
15 tasks
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
…s#692)

* Spike for parallel relaying between multiple channels

* Adjust event heights

* Re-use existing Link infra for relaying packets

* Formatting

* Use only source chain, channel and port to identify packets

* Force use of in-memory store

* Fix computation of UnidrectionalChannelPath for WriteAck

* Run two supervisors in parallel

* Relay in both directions with a single supervisor

* Revert "Force use of in-memory store"

This reverts commit b197537.

* Move supervisor into ibc-relayer crate

* Formatting

* Remove println statements

* Formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants