Misbehavior monitoring and handling

[ancazamfir]

Closes: #632

Description

• Added header and deserialization in UpdateClient event and Tx result output for CLIs
• Extract header from UpdateClient transactions
• Get headers from query_tx()
• Misbehaviour event deserialization
• Added the hermes misbehaviour command for monitoring a given client on a chain
• Fix tx raw create-client to not allow same source and dest chains
• Removed src chain from tx raw update-client as it is redundant
• Added target and trusted heights to tx raw update-client to allow testing with different updates.
• Added option to query all consensus states and also display only the heights.
• Added new command to query header used when a consensus state was created.
• Submit evidence supported for headers at same height but different BlockId-s and also for BFT time violation.
• Checks previous updates on hermes (re)start.
• Added query_clients() to the runtime.

---

For contributor use:

• Updated the Unreleased section of CHANGELOG.md with the issue.
• If applicable: Unit tests written, added test to CI.
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Updated relevant documentation (docs/) and code comments.
• Re-reviewed Files changed in the Github PR explorer.

[codecov-io]

Codecov Report

Merging #691 (d7293dd) into master (b1b37f5) will increase coverage by 29.4%.
The diff coverage is n/a.

❗ Current head d7293dd differs from pull request most recent head 3942d74. Consider uploading reports for the commit 3942d74 to get more accurate results

@@            Coverage Diff            @@
##           master    #691      +/-   ##
=========================================
+ Coverage    13.6%   43.1%   +29.4%     
=========================================
  Files          69     171     +102     
  Lines        3752   11883    +8131     
  Branches     1374       0    -1374     
=========================================
+ Hits          513    5123    +4610     
- Misses       2618    6760    +4142     
+ Partials      621       0     -621     

Impacted Files	Coverage Δ
...application/ics20_fungible_token_transfer/error.rs	0.0% <ø> (ø)
...ion/ics20_fungible_token_transfer/msgs/transfer.rs	22.2% <ø> (ø)
..._transfer/relay_application_logic/send_transfer.rs	85.7% <ø> (ø)
modules/src/events.rs	0.0% <ø> (ø)
modules/src/handler.rs	100.0% <ø> (ø)
modules/src/ics02_client/client_consensus.rs	41.3% <ø> (ø)
modules/src/ics02_client/client_def.rs	32.3% <ø> (ø)
modules/src/ics02_client/client_state.rs	65.1% <ø> (ø)
modules/src/ics02_client/client_type.rs	79.1% <ø> (+31.5%)	⬆️
modules/src/ics02_client/context.rs	90.4% <ø> (ø)
... and 276 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c72c28...3942d74. Read the comment docs.

[ancazamfir]

this seems a little odd to me. The header bytes should contain the type_url? This is the definition in the SDK. I don't know rust, but it looks like you are creating an Any by passing in the type url using a constant and then trying to decode the encoded any into the value of the Any?

This was with a version that you had where you were not using Any.

[adizere]

This is impressive, great work Anca!

I left several suggestions, but should be treated as lower priority. I didn't get the chance to look closely at the important part in ForeignClient::handle_misbehaviour.

[romac]

Great work @ancazamfir! Pushed a couple commits with some minor changes (none semantics) and otherwise left a bunch of comments and suggestions inline.

[ancazamfir]

Thanks @romac, @cezarad and @adizere for the great comments!! I think I addressed most of them but please double check.