Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation failures #526

Merged
merged 8 commits into from
Jan 15, 2021
Merged

Compilation failures #526

merged 8 commits into from
Jan 15, 2021

Conversation

adizere
Copy link
Member

@adizere adizere commented Jan 15, 2021

Closes: #525

Description


For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@adizere adizere marked this pull request as ready for review January 15, 2021 10:22
@codecov-io
Copy link

codecov-io commented Jan 15, 2021

Codecov Report

Merging #526 (0ffc8a6) into master (b1b37f5) will increase coverage by 15.7%.
The diff coverage is 56.4%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #526      +/-   ##
=========================================
+ Coverage    13.6%   29.4%   +15.7%     
=========================================
  Files          69     161      +92     
  Lines        3752   13064    +9312     
  Branches     1374    5155    +3781     
=========================================
+ Hits          513    3847    +3334     
- Misses       2618    8969    +6351     
+ Partials      621     248     -373     
Impacted Files Coverage Δ
...application/ics20_fungible_token_transfer/error.rs 0.0% <0.0%> (ø)
...pplication/ics20_fungible_token_transfer/events.rs 0.0% <ø> (ø)
...ion/ics20_fungible_token_transfer/msgs/transfer.rs 0.0% <0.0%> (ø)
modules/src/events.rs 0.0% <0.0%> (ø)
modules/src/ics02_client/events.rs 0.0% <0.0%> (ø)
modules/src/ics02_client/msgs.rs 0.0% <0.0%> (ø)
modules/src/ics02_client/raw.rs 0.0% <0.0%> (ø)
modules/src/ics03_connection/error.rs 12.5% <0.0%> (-20.9%) ⬇️
modules/src/ics03_connection/events.rs 0.0% <0.0%> (ø)
modules/src/ics04_channel/error.rs 75.0% <ø> (+50.0%) ⬆️
... and 283 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 239fd6f...0ffc8a6. Read the comment docs.

@adizere adizere merged commit 9eda47b into master Jan 15, 2021
@adizere adizere deleted the adi/525_deps branch January 15, 2021 13:02
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
* trying (again) with fixed .25 bitcoin lib

* trying (again) with fixed .25.2 bitcoin lib

* Reverted bitcoin lib ver. Resorting to from_str

* Some discipline on imports. FMT

* FMT second try

* Revert "trying (again) with fixed .25 bitcoin lib"

This reverts commit e7a825d.

* Trying with simple DerivationPath::from() and aligned deps

* Pin to latest bitcoi version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation failure due to mismatching bitcoin dependencies in v0.0.6
3 participants