-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Investigation into replacing anomaly
with eyre
for error handling
#493
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov Report
@@ Coverage Diff @@
## master #493 +/- ##
=========================================
+ Coverage 13.6% 29.3% +15.6%
=========================================
Files 69 160 +91
Lines 3752 12891 +9139
Branches 1374 4989 +3615
=========================================
+ Hits 513 3785 +3272
- Misses 2618 8418 +5800
- Partials 621 688 +67
Continue to review full report at Codecov.
|
adizere
changed the title
Investigation into replacing
WIP Investigation into replacing Jan 5, 2021
anomaly
with eyre
for error handlinganomaly
with eyre
for error handling
The test "incorrect versions" was not exercising an failing path due to mismatching versions, but was failing because of error in consensus state verification (ConsensusStateVerificationFailure). This test is no longer useful since all versions are set to the default and therefore always match, so there is no failing path to test.
Retiring this PR, we'll leave the work for later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #68
The PR in its current form is an experiment with replacing anomaly with eyre.
Only the following components have transitioned to eyre:
If we're satisfied with eyre, we'll continue porting all of ibc-rs in a couple more separate PRs.
Discussion here: #68 (comment)
For contributor use:
docs/
) and code comments.Files changed
in the Github PR explorer.