Local chain implementation & basic tests #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #422 +/- ##
=========================================
+ Coverage 13.6% 39.0% +25.4%
=========================================
Files 69 156 +87
Lines 3752 11197 +7445
Branches 1374 4308 +2934
=========================================
+ Hits 513 4377 +3864
- Misses 2618 6194 +3576
- Partials 621 626 +5
Continue to review full report at Codecov.
|
adizere
commented
Dec 2, 2020
| @@ -19,7 +19,7 @@ use crate::ics02_client::error::{Error, Kind}; | |||
| use crate::ics24_host::identifier::ClientId; | |||
| use crate::tx_msg::Msg; | |||
|
|
|||
| const TYPE_MSG_CREATE_CLIENT: &str = "create_client"; | |||
| pub const TYPE_URL: &str = "/ibc.core.client.v1.MsgCreateClient"; | |||
There was a problem hiding this comment.
FYI: Introduced these public constants in all messages to be able to use them in pattern matching, which is useful in the ICS26 handler:
adizere
commented
Dec 2, 2020
| Ok(key) | ||
| } | ||
|
|
||
| fn build_client_state(&self, height: ICSHeight) -> Result<Self::ClientState, Error> { |
There was a problem hiding this comment.
These methods are unchanged, just moved around to appear in the same order here as in trait Chain.
adizere
changed the title
This reverts commit 43bd008. In anticipation of merging master into this dev branch..
ancazamfir
requested changes
Dec 3, 2020
ancazamfir
approved these changes
Dec 3, 2020
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
* Attemptin integration at the level of Chain trait * Removed rpc client from trait Chain * Removed ChainConfig from trait Chain * Minor fixes as follow-up from informalsystems#364 * Impl generic runtime instantiation. * Migrated CLIs to use generic runtime spawn. * Added mock light client. First test (incomplete impl). * Almost ready to send_tx (mock has to be mutable). * Added chain executor. * Mutable chain in send_tx, simplified spawn.After review w/ Anca & Romain * impl CosmosSDKChain cleanup * Adapted mock context, ICS18 & 26 to correct abstractions. * Cleaned up Msg trait, added const TYPE_URL. * Basic light client impl to complete create client test. * Removed clippy allow exception * Updated changelog * Revert "Updated changelog" This reverts commit 43bd008. In anticipation of merging master into this dev branch.. * Redid the changelog * After Anca's comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #158
For contributor use:
docs/) and code comments.Files changedin the Github PR explorer.