Handshake impls from relayer loop

[ancazamfir]

Closes: #376
Closes: #377
Closes: #378

Description

• Triggered from rrly -c config.toml v-0, added a polling loop for client, connection and channel.
• Refactored some of the CLI code and signature of the supporting relayer functions.
• Moved the code from relayer/src/tx in the corresponding relayer modules.

Testing

Currently works with a known issue from the light client:

The application panicked (crashed).
Message:  called `Result::unwrap()` on an `Err` value: Error(Context { kind: LightClient, source: Some(Error(Context { kind: NoWitnesses, source: None, backtrace: Some(   0: backtrace::backtrace::libunwind::trace

Also getting some RPC errors in the monitors once in a while, will debug, but in this case the handshake continues fine

Other mentions

• removed flexible connection Id for connOpenInit as this is being heavily reworked in ICS and will be avail in future cosmos-sdk release. Will pick it up again as part of integration with stargate-? next releases.
• relayer::config should hold type Ids, code is currently quite verbose to do the Id checks all the time
• there is overlap between relayer::config and ConnectionConfig, ForeignClientConfig and ChannelConfig. These should be consolidated

---

For contributor use:

• Updated the Unreleased section of CHANGELOG.md with the issue.
• If applicable: Unit tests written, added test to CI.
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Updated relevant documentation (docs/) and code comments.
• Re-reviewed Files changed in the Github PR explorer.

[codecov-io]

Codecov Report

Merging #421 (2bc4d44) into master (b1b37f5) will increase coverage by 23.0%.
The diff coverage is 67.5%.

@@            Coverage Diff            @@
##           master    #421      +/-   ##
=========================================
+ Coverage    13.6%   36.7%   +23.0%     
=========================================
  Files          69     154      +85     
  Lines        3752   11090    +7338     
  Branches     1374    4263    +2889     
=========================================
+ Hits          513    4072    +3559     
- Misses       2618    6382    +3764     
- Partials      621     636      +15     

Impacted Files	Coverage Δ
modules/src/events.rs	0.0% <0.0%> (ø)
modules/src/ics02_client/events.rs	0.0% <ø> (ø)
modules/src/ics02_client/msgs.rs	0.0% <0.0%> (ø)
modules/src/ics02_client/raw.rs	0.0% <0.0%> (ø)
modules/src/ics03_connection/error.rs	13.6% <0.0%> (-19.7%)	⬇️
modules/src/ics04_channel/error.rs	75.0% <ø> (+50.0%)	⬆️
modules/src/ics04_channel/msgs/chan_open_try.rs	67.0% <ø> (ø)
modules/src/ics04_channel/msgs/recv_packet.rs	63.5% <ø> (ø)
modules/src/ics04_channel/msgs/timeout.rs	69.2% <ø> (ø)
modules/src/ics04_channel/packet.rs	70.4% <ø> (+70.4%)	⬆️
... and 286 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db44b16...2bc4d44. Read the comment docs.

[romac]

@ancazamfir Can you please expand a bit on what is the problem here?

there is an issue, I believe runtime related, cannot call build_conn_and_send() directly, had to call separately build_conn() and then dst_chain.send_tx(). So currently, in the poll loop for both connection and channel, you will notice these two calls at every step.

[ancazamfir]

@ancazamfir Can you please expand a bit on what is the problem here?

I don't see this anymore, will remove from the list.

[ancazamfir]

No errors with light client verification disabled:

$ rrly -c loop_config.toml v-0
    Finished dev [unoptimized + debuginfo] target(s) in 1.19s
     Running `target/debug/relayer -c loop_config.toml v-0`
Nov 26 17:28:46.732  INFO relayer::event::monitor: running listener chain.id=ibc0
Nov 26 17:28:46.806  INFO relayer::event::monitor: running listener chain.id=ibc1
🍭  Client on ChainId { id: "ibc0", version: 0 } is created ClientId("ibc0client166")

🍭  Client on ChainId { id: "ibc1", version: 0 } is created ClientId("ibc0client166")

🥂  ConnInit ConnectionSideConfig { chain_id: ChainId { id: "ibc0", version: 0 }, connection_id: ConnectionId("ibc0connection166"), client_id: ClientId("ibc0client166") }
elapsed time 4

🥂  ConnTry ConnectionSideConfig { chain_id: ChainId { id: "ibc1", version: 0 }, connection_id: ConnectionId("ibc1connection166"), client_id: ClientId("ibc0client166") }
elapsed time 13

🥂  ConnAck ConnectionSideConfig { chain_id: ChainId { id: "ibc0", version: 0 }, connection_id: ConnectionId("ibc0connection166"), client_id: ClientId("ibc0client166") }
elapsed time 12

🥂  ConnConfirm ConnectionSideConfig { chain_id: ChainId { id: "ibc1", version: 0 }, connection_id: ConnectionId("ibc1connection166"), client_id: ClientId("ibc0client166") }
elapsed time 8

🥂  🥂  🥂  Connection handshake finished for [ConnectionConfig {
    a_config: ConnectionSideConfig {
        chain_id: ChainId {
            id: "ibc0",
            version: 0,
        },
        connection_id: ConnectionId(
            "ibc0connection166",
        ),
        client_id: ClientId(
            "ibc0client166",
        ),
    },
    b_config: ConnectionSideConfig {
        chain_id: ChainId {
            id: "ibc1",
            version: 0,
        },
        connection_id: ConnectionId(
            "ibc1connection166",
        ),
        client_id: ClientId(
            "ibc0client166",
        ),
    },
}]
🥳  ChanInit ChannelConfigSide { chain_id: ChainId { id: "ibc0", version: 0 }, connection_id: ConnectionId("ibc0connection166"), client_id: ClientId("ibc0client166"), port_id: PortId("transfer"), channel_id: ChannelId("ibc0xfer166") }
elapsed time 4

🥳  ChanTry ChannelConfigSide { chain_id: ChainId { id: "ibc1", version: 0 }, connection_id: ConnectionId("ibc1connection166"), client_id: ClientId("ibc0client166"), port_id: PortId("transfer"), channel_id: ChannelId("ibc0xfer166") }
elapsed time 8

🥳  ChanAck ChannelConfigSide { chain_id: ChainId { id: "ibc0", version: 0 }, connection_id: ConnectionId("ibc0connection166"), client_id: ClientId("ibc0client166"), port_id: PortId("transfer"), channel_id: ChannelId("ibc0xfer166") }
elapsed time 6

🥳  ChanConfirm ChannelConfigSide { chain_id: ChainId { id: "ibc1", version: 0 }, connection_id: ConnectionId("ibc1connection166"), client_id: ClientId("ibc0client166"), port_id: PortId("transfer"), channel_id: ChannelId("ibc0xfer166") }
elapsed time 8

🥳  🥳  🥳  Channel handshake finished for ChannelConfig {
    ordering: Unordered,
    a_config: ChannelConfigSide {
        chain_id: ChainId {
            id: "ibc0",
            version: 0,
        },
        connection_id: ConnectionId(
            "ibc0connection166",
        ),
        client_id: ClientId(
            "ibc0client166",
        ),
        port_id: PortId(
            "transfer",
        ),
        channel_id: ChannelId(
            "ibc0xfer166",
        ),
    },
    b_config: ChannelConfigSide {
        chain_id: ChainId {
            id: "ibc1",
            version: 0,
        },
        connection_id: ConnectionId(
            "ibc1connection166",
        ),
        client_id: ClientId(
            "ibc0client166",
        ),
        port_id: PortId(
            "transfer",
        ),
        channel_id: ChannelId(
            "ibc0xfer166",
        ),
    },
}