Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use patched tendermint-rs for deserializing Sei's block_results correctly #3836

Closed
wants to merge 2 commits into from
Closed

Use patched tendermint-rs for deserializing Sei's block_results correctly #3836

wants to merge 2 commits into from

Conversation

romac
Copy link
Member

@romac romac commented Feb 2, 2024

See: #3817

Description

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@romac romac changed the title Use patched tendermint-rs for deserializing Seis block_results correctly Use patched tendermint-rs for deserializing Sei's block_results correctly Feb 2, 2024
@romac romac mentioned this pull request Feb 2, 2024
Closed
5 tasks
@romac romac added this to the v1.9 milestone Mar 12, 2024
@romac
Copy link
Member Author

romac commented Mar 21, 2024 •
edited
Loading

Will be superseded by #3895

@romac romac closed this Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Hermes
Status: ✅ Done
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
1 participant
@romac