Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CosmosSdk as the chain type if omitted, for backward compatibility #3787

Merged
merged 3 commits into from
Jan 18, 2024
Merged

Use CosmosSdk as the chain type if omitted, for backward compatibility #3787

merged 3 commits into from
Jan 18, 2024

Commits on Jan 16, 2024

  1. Use CosmosSdk as the chain type if omitted, for backward compatibility 

    Doing this requires a bit of hack, due to serde's lack of support
for specifying a default variant when a tag is not provided.

See the doc comment on the `ChainConfig` struct for more details.
    @romac
    romac committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    35321c6 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. Add parsing test for default chain type

    @ljoss17
    ljoss17 committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    20392ab View commit details
    Browse the repository at this point in the history

  2. Check we parse the correct default type

    @romac
    romac committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    19df4bb View commit details
    Browse the repository at this point in the history