Transaction signing #345
Merged
Transaction signing #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing because there's an issue with the way the signer is specified on tests. In the transaction signing of the raw message (proto) the signer is the bech32 account address. |
Codecov Report
@@ Coverage Diff @@
## master #345 +/- ##
=========================================
+ Coverage 13.6% 35.0% +21.4%
=========================================
Files 69 137 +68
Lines 3752 8582 +4830
Branches 1374 2964 +1590
=========================================
+ Hits 513 3012 +2499
- Misses 2618 5380 +2762
+ Partials 621 190 -431
Continue to review full report at Codecov.
|
ancazamfir
approved these changes
Oct 29, 2020
There was a problem hiding this comment.
Hi Andy, thanks again for working on this! I have a few comments but could be solved in different PRs. Haven't looked at the keyring stuff in detail, mostly at the IBC changes. We should start a conversation about the best way to refactor the auth, signing, keystore, etc. But for now I think this is good to go.
I had this in place so I could test. OK to change it back Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com>
OK, didn't know where to get it from, thanks. Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com>
ancazamfir
approved these changes
Oct 30, 2020
|
I believe we discussed most of the reviews on this draft PR and should be good for Review. Some of the discussions will lead into other issues/features that are outside the scope of this PR for now. |
andynog
added a commit
that referenced
this pull request
Oct 30, 2020
This was referenced Nov 3, 2020
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
* Initial implementation for tx sign * Adding logic to build the tx as part of the chain. Added broadcast tx to chain. informalsystems#47 * Added keys restore command boileplate for abscissa. Restore key functionality not implemented yet informalsystems#47 * Implemented changes to support tx signing (informalsystems#47): * Implemented very basic keybase to store keys (memory store) * Logic to restore key (private/public) from mnemonic * Added keystore to the chain * Implemented working 'keys restore' command on the relayer * Refactoring keybase structure (informalsystems#47) * Initial logic to send message (informalsystems#47) * Got the logic to sign but MsgConnectionOpenInit test against stargate-4 not working (informalsystems#47) * MsgConnectionOpenInit tx working logic! (informalsystems#47) * Added option to tx raw conn-init to specify and read key file content (informalsystems#47) * Logic to parse the key_seed.json file passed as tx raw parameter working (informalsystems#47) * Added support to specify key file and account sequence for the tax raw conn-init command (informalsystems#47) * Adding instructions on how to submit a transaction (informalsystems#345) * Fixing format issues (informalsystems#345) * Fixing tests (informalsystems#345) * Update relayer/src/tx/client.rs I had this in place so I could test. OK to change it back Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com> * Update relayer/src/tx/connection.rs OK, didn't know where to get it from, thanks. Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com> Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #47
Description
This PR includes the logic to sign Tx. Currently there is logic to sign a MsgConnectionOpenInit against a gaia stargate-4 chain.
Will open this PR as a draft because even though the code works there's a few things to be worked on (bugs, tests) but it's easier to track through a PR than on the issue.
For contributor use:
docs/) and code comments.Files changedin the Github PR explorer.