Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement query_header_at_height via plain RPC queries (no light client verification) #344

Merged
merged 2 commits into from
Oct 28, 2020
Merged

Implement query_header_at_height via plain RPC queries (no light client verification) #344

merged 2 commits into from
Oct 28, 2020

Conversation

romac
Copy link
Member

@romac romac commented Oct 27, 2020

See: #336

Description

First part of #336, ie. implement query_header_at_height via plain RPC queries.

For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@romac romac requested a review from ancazamfir October 27, 2020 15:33
ancazamfir
ancazamfir approved these changes Oct 27, 2020
View reviewed changes
Copy link
Collaborator

@ancazamfir ancazamfir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks Romain!

@ancazamfir ancazamfir merged commit 052b574 into master Oct 28, 2020
@romac romac deleted the romac/query-header-at-height-no-verif branch December 15, 2020 13:14
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@romac
Implement query_header_at_height via plain RPC queries (no light cl…
9160313 
…ient verification) (informalsystems#344)

* Implement query_header_at_height via RPC (no light client verification)

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ancazamfir ancazamfir ancazamfir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romac @ancazamfir