Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send consumer misbehaviour message IcsConsumerMisbehaviour to the provider #3220

Merged
merged 11 commits into from
Apr 12, 2023
Merged

Send consumer misbehaviour message IcsConsumerMisbehaviour to the provider #3220

merged 11 commits into from
Apr 12, 2023

Conversation

ancazamfir
Copy link
Collaborator

@ancazamfir ancazamfir commented Apr 4, 2023 •
edited by romac
Loading

Closes: #3219

Description

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@romac romac marked this pull request as ready for review April 12, 2023 10:50
@romac romac changed the title Send consumer misbehaviour message IcsConsumerMisbehaviour to the provider Send consumer misbehaviour message IcsConsumerMisbehaviour to the provider Apr 12, 2023
@romac romac merged commit 188dc72 into master Apr 12, 2023
@romac romac deleted the anca/ics-misbehaviour-handling branch April 12, 2023 10:59
@romac romac restored the anca/ics-misbehaviour-handling branch April 12, 2023 17:11
romac added a commit that referenced this pull request Apr 14, 2023
@romac
Revert "Send consumer misbehaviour message IcsConsumerMisbehaviour …
4bcf964 
…to the provider (#3220)"

This reverts commit 188dc72.
@romac romac mentioned this pull request Apr 14, 2023
Merged
@romac romac deleted the anca/ics-misbehaviour-handling branch April 26, 2023 15:22
@romac romac restored the anca/ics-misbehaviour-handling branch May 24, 2023 09:17
romac added a commit that referenced this pull request May 24, 2023
@romac
Revert "Send consumer misbehaviour message IcsConsumerMisbehaviour …
376ecc5 
…to the provider (#3220)" (#3242)

This reverts commit 188dc72.
pratikbin pushed a commit to pratikbin/hermes that referenced this pull request May 24, 2023
@romac
Revert "Send consumer misbehaviour message IcsConsumerMisbehaviour …
3190dfe 
…to the provider (informalsystems#3220)" (informalsystems#3242)

This reverts commit 188dc72.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romac romac romac approved these changes

Assignees

@romac romac

@ancazamfir ancazamfir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

For CCV send consumer misbehaviour message (IcsConsumerMisbehaviour) to the provider
2 participants
@ancazamfir @romac