Allowing different chain binaries for integration tests #2909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…length and added test between Gaia6 and Gaia7
…of same length and added test between Gaia6 and Gaia7" This reverts commit be0a746.
…multi version CI integration tests
soareschen
requested changes
Dec 6, 2022
.github/workflows/integration.yaml
Outdated
| fail-fast: false | ||
| matrix: | ||
| package1: [.#gaia6, .#gaia7, .#gaia8, .#ibc-go-v2-simapp, .#ibc-go-v3-simapp, .#ibc-go-v4-simapp, .#ibc-go-v5-simapp, .#ibc-go-v6-simapp, .#wasmd, .#evmos, .#osmosis] | ||
| package2: [.#gaia6, .#gaia7, .#gaia8, .#ibc-go-v2-simapp, .#ibc-go-v3-simapp, .#ibc-go-v4-simapp, .#ibc-go-v5-simapp, .#ibc-go-v6-simapp, .#wasmd, .#evmos, .#osmosis] |
There was a problem hiding this comment.
I think we could make it a matrix of dictionaries. Something like:
matrix:
first-package:
- package: gaia6
chain_command_path: gaiad
account_prefix: cosmos
Then we don't need the exclude list below.
Btw I am not quite sure why we need to specify the .# prefix everywhere here. It might be simpler to write it as nix shell .#${{ matrix.first_package.package }}.
There was a problem hiding this comment.
Oh I see good idea thank you.
The prefix .# is from an earlier solution, it is not needed anymore I will remove it
…st. Removed unncessary .# prefix
…thub.com:informalsystems/hermes into luca_joss/different-chains-for-integration-tests
soareschen
approved these changes
Dec 7, 2022
| @@ -114,6 +114,123 @@ jobs: | |||
| test -p ibc-integration-test --no-fail-fast -- \ | |||
| --nocapture --test-threads=2 | |||
|
|
|||
| multi-chains-test: | |||
| runs-on: ubuntu-latest | |||
| if: github.ref == 'refs/heads/master' | |||
There was a problem hiding this comment.
Can we comment this to test on this branch, and then uncomment it again before merging once this pass?
soareschen
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2003
Description
This PR changes the environment variables
CHAIN_COMMAND_PATHandACCOUNT_PREFIXtoCHAIN_COMMAND_PATHSandACCOUNT_PREFIXESwhich now take a coma separated list of string. This means that the old format still works. e.g.:Which will run all tests with
gaia8.But a new format is available, e.g.:
Which will run single chain tests with
gaia8, binary chain tests withgaia8 <-> evmosand N-ary chain tests will have alternatinggaia8andevmoschains.New CI job
The new CI job,
multi-chains-test, which runs the tests with all combinations of chains can be seen here https://github.com/informalsystems/hermes/actions/runs/3628936071/jobs/6120570278PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.