Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove proto crates from the repository #2667

Merged
merged 22 commits into from
Oct 4, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .changelog/config.toml
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ entry_indent = 2
[components.all]
chain-registry = { name = "Chain Registry", path = "chain-registry" }
ibc = { name = "IBC Modules", path = "modules" }
ibc-proto = { name = "IBC Proto", path = "proto" }
ibc-relayer = { name = "Relayer Library", path = "relayer" }
ibc-relayer-cli = { name = "Relayer CLI", path = "relayer-cli" }
ibc-telemetry = { name = "Telemetry & Metrics", path = "telemetry" }
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Fix incorrect Github workflow trigger paths.
([#2667](https://github.com/informalsystems/ibc-rs/issues/2667))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Delete the `ibc-proto` and `ibc-proto-compiler` crates from the repository.
([#2667](https://github.com/informalsystems/ibc-rs/issues/2667))
21 changes: 3 additions & 18 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,32 +12,17 @@ updates:
interval: "weekly"

- package-ecosystem: "cargo"
directory: "modules"
directory: "crates/modules"
schedule:
interval: "weekly"

- package-ecosystem: "cargo"
directory: "proto"
schedule:
interval: "weekly"

## Disable dependabot for `proto-compiler`.
## Rationale: we maintain the dependencies for proto-compiler
## manually, so that we update the proto-compiler binary
## (and the Cargo.lock file) only when we regenerate
## Rust types from the .proto files.
# - package-ecosystem: "cargo"
# directory: "proto-compiler"
# schedule:
# interval: "weekly"

- package-ecosystem: "cargo"
directory: "relayer"
directory: "crates/relayer"
schedule:
interval: "weekly"

- package-ecosystem: "cargo"
directory: "relayer-cli"
directory: "crates/relayer-cli"
schedule:
interval: "weekly"

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/cargo-doc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,5 @@ jobs:
uses: peaceiris/actions-gh-pages@v3
with:
deploy_key: ${{ secrets.IBC_RS_DOC_PRIVATE_KEY }}
external_repository: informalsystems/ibc-rs-doc
external_repository: informalsystems/hermes-doc
publish_dir: ./target/doc
12 changes: 2 additions & 10 deletions .github/workflows/guide-templates.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,23 +3,15 @@ on:
pull_request:
paths:
- .github/workflows/guide-templates.yaml
- modules/**
- relayer/**
- relayer-cli/**
- relayer-rest/**
- telemetry/**
- crates/**
- scripts/**
- tools/check-guide/**

push:
branches: master
paths:
- .github/workflows/guide-templates.yaml
- modules/**
- relayer/**
- relayer-cli/**
- relayer-rest/**
- telemetry/**
- crates/**
- scripts/**
- tools/check-guide/**

Expand Down
14 changes: 2 additions & 12 deletions .github/workflows/integration.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,7 @@ on:
- flake.lock
- ci/**
- e2e/**
- proto/**
- modules/**
- relayer/**
- relayer-cli/**
- relayer-rest/**
- telemetry/**
- crates/**
- tools/**
push:
branches: master
Expand All @@ -26,12 +21,7 @@ on:
- flake.lock
- ci/**
- e2e/**
- proto/**
- modules/**
- relayer/**
- relayer-cli/**
- relayer-rest/**
- telemetry/**
- crates/**
- tools/**

env:
Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/no-std.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,15 @@ on:
- Cargo.toml
- Cargo.lock
- ci/**
- proto/**
- modules/**
- crates/modules/**
push:
branches: master
paths:
- .github/workflows/no-std.yml
- Cargo.toml
- Cargo.lock
- ci/**
- proto/**
- modules/**
- crates/modules/**

jobs:
check-no-std-panic-conflict:
Expand Down
14 changes: 2 additions & 12 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,7 @@ on:
- Cargo.lock
- ci/**
- e2e/**
- proto/**
- modules/**
- relayer/**
- relayer-cli/**
- relayer-rest/**
- telemetry/**
- crates/**
- tools/**
push:
branches: master
Expand All @@ -22,12 +17,7 @@ on:
- Cargo.lock
- ci/**
- e2e/**
- proto/**
- modules/**
- relayer/**
- relayer-cli/**
- relayer-rest/**
- telemetry/**
- crates/**
- tools/**

env:
Expand Down
3 changes: 0 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -236,9 +236,6 @@ Our release process is as follows:
parameters must point to the new version.
3. Every reference to Hermes version in the [guide](./guide).

**Important:** The `ibc-proto` crate version must only be bumped if it has
changed since the last release. All other crates are bumped together.

4. Run `cargo doc --all-features --open` locally to double-check that all the
documentation compiles and seems up-to-date and coherent. Fix any potential
issues here and push them to the release PR.
Expand Down
Loading