-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support custom extension options when building tx #2573
Conversation
If I understand correctly, this would be used as follows in the config file: [[chains]]
id = '...'
# ...
extension_options = [
{ type = "ethermint_dynamic_fee", value = "10" }
] Right? For our understanding, can you please elaborate on what this means for Ethermint? It's not super clear in the issue what are the semantics of that extension. |
Yes, there's some contexts here: #2350 (comment), it's needed to fix the reorder issue after we enable the tx priority and feemarket. |
We did an integration test with it: crypto-org-chain/cronos#652 |
@romac what's your opinion on this? this is necessary for all ethermint chains, including cronos and evmos. |
I am in favor of this change, thank you very much for suggesting it. Unfortunately, it won't make it into v1.0 (which will go very soon) but we will merge and release it into Hermes v1.1. |
Closes: informalsystems#2566 * Support custom extension options when building tx * Cargo.lock is outdated * optimize serde encoding * fix clippy and test * Add changelog entry * Fix clippy warnings * Fix compilation * Fix clippy warnings Co-authored-by: Sean Chen <seanchen11235@gmail.com> Co-authored-by: Romain Ruetschi <romain@informal.systems>
Description
Closes: #2566
Support custom extension options to be able to specify max_priority_price in ethermint dynamic fee tx.
PR author checklist:
unclog
.docs/
).Reviewer checklist:
Files changed
in the GitHub PR explorer.