Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICS02 mock extensions + more tests in ICS02 and ICS03 #222

Merged
merged 9 commits into from
Sep 10, 2020
Merged

Conversation

adizere
Copy link
Member

@adizere adizere commented Sep 8, 2020

Closes: cosmos/ibc-rs#114


For contributor use:

  • Unit tests written
  • Added test to CI if applicable
  • Updated CHANGELOG_PENDING.md
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments
  • Re-reviewed Files changed in the Github PR explorer

@codecov-commenter
Copy link

Codecov Report

Merging #222 into master will increase coverage by 25.6%.
The diff coverage is 56.8%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    informalsystems/hermes#222      +/-   ##
=========================================
+ Coverage    13.6%   39.2%   +25.6%     
=========================================
  Files          69      78       +9     
  Lines        3752    5257    +1505     
  Branches     1374    1794     +420     
=========================================
+ Hits          513    2065    +1552     
- Misses       2618    3044     +426     
+ Partials      621     148     -473     
Impacted Files Coverage Δ
modules/src/events.rs 0.0% <ø> (ø)
modules/src/ics02_client/events.rs 0.0% <ø> (ø)
modules/src/ics02_client/raw.rs 0.0% <0.0%> (ø)
modules/src/ics03_connection/error.rs 11.5% <0.0%> (-21.8%) ⬇️
modules/src/ics04_channel/error.rs 23.0% <0.0%> (-2.0%) ⬇️
modules/src/ics04_channel/packet.rs 0.0% <0.0%> (ø)
modules/src/ics07_tendermint/client_def.rs 0.0% <0.0%> (ø)
modules/src/ics07_tendermint/error.rs 33.3% <0.0%> (+33.3%) ⬆️
modules/src/ics07_tendermint/msgs/update_client.rs 0.0% <0.0%> (ø)
modules/src/mock_client/client_def.rs 0.0% <0.0%> (ø)
... and 124 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf6c815...bbd2105. Read the comment docs.

@adizere adizere marked this pull request as ready for review September 8, 2020 14:54
Copy link
Member

@romac romac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

modules/src/mock_client/state.rs Outdated Show resolved Hide resolved
pub struct MockConnectionContext {
chain_context: MockChainContext,
client_context: MockClientContext,
connections: HashMap<ConnectionId, ConnectionEnd>,
client_connections: HashMap<ClientId, ConnectionId>,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be in the client context. We can discuss and change it in a different PR.

Copy link
Collaborator

@ancazamfir ancazamfir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one minor comment.

@adizere adizere merged commit 4128596 into master Sep 10, 2020
@adizere adizere deleted the adi/221_mock branch September 10, 2020 08:03
@adizere adizere added this to the v0.0.4 milestone Sep 10, 2020
@adizere adizere removed this from the v0.0.4 milestone Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants