-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICS02 mock extensions + more tests in ICS02 and ICS03 #222
Conversation
Codecov Report
@@ Coverage Diff @@
## master informalsystems/hermes#222 +/- ##
=========================================
+ Coverage 13.6% 39.2% +25.6%
=========================================
Files 69 78 +9
Lines 3752 5257 +1505
Branches 1374 1794 +420
=========================================
+ Hits 513 2065 +1552
- Misses 2618 3044 +426
+ Partials 621 148 -473
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
pub struct MockConnectionContext { | ||
chain_context: MockChainContext, | ||
client_context: MockClientContext, | ||
connections: HashMap<ConnectionId, ConnectionEnd>, | ||
client_connections: HashMap<ClientId, ConnectionId>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be in the client context. We can discuss and change it in a different PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one minor comment.
Closes: cosmos/ibc-rs#114
For contributor use:
docs/
) and code commentsFiles changed
in the Github PR explorer