-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ADR 009: ChainEndpoint
and ChainHandle
methods standardization
#2200
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
e67091a
QueryChannelClientStateRequest domain type
plafer 7a74ad5
QueryChannelClientStateRequest domain type
plafer 75cbbe9
QueryChannelRequest domain type
plafer c9b9bca
QueryChannelClientStateRequest: remove unused Protobuf
plafer fd2dff9
clippy
plafer daf8afb
PageRequest domain type
plafer ce1ea14
QueryClientStatesRequest domain type
plafer c50ff36
QueryClientStateRequest domain type
plafer d789657
QueryConsensusStatesRequest domain type
plafer bdc856c
bunch of domain types
plafer 93ea59c
bunch of domain types
plafer 0fe2a2d
rest of domain types
plafer 95824c9
changelog
plafer 0a8452c
Update relayer-cli/src/commands/misbehaviour.rs
plafer b354443
remove extraneous `request` vars
plafer e3f5b89
Merge remote-tracking branch 'origin/master' into plafer/2192-adr009-…
plafer 8dd989b
Merge remote-tracking branch 'origin/master' into plafer/2192-adr009-…
plafer 400d61c
Use MerkleProof domain type
plafer ec906f0
Remove `PacketState` return from queries
plafer 238fb3b
Use existing Sequence domain type
plafer dbe5e39
Merge branch 'master' into plafer/2192-adr009-impl
romac File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
2 changes: 2 additions & 0 deletions
2
.changelog/unreleased/improvements/relayer/2192-adr009-impl.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
- Implement ADR 9: add domain type for request messages that are passed to query | ||
functions ([#2192](https://github.com/informalsystems/ibc-rs/issues/2192)) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: What's a
RawMerkleProof
and when is it appropriate to use it vs. a "regular"MerkleProof
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
RawMerkleProof
is the type that is defined in ibc-go's protobuf files.MerkleProof
here is our own domain type for it, and hence we should use it everywhere in our codebase except when it's time to interact with a gRPC endpoint (where we convert ourMerkleProof
back into aRawMerkleProof
to be sent on the wire)