Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test ordered channel relaying with concurrent relayers #2024

Closed
wants to merge 6 commits into from

Conversation

soareschen
Copy link
Contributor

@soareschen soareschen commented Mar 28, 2022

Closes: #2010

Depends on #2044

Description

This is a work in progress to test #2010. Some refactoring on the test framework is needed before this can be properly merged.

At a first glance, there don't seem to be obvious issue of relaying ordered channel packets when multiple relayers are racing on it. So hopefully there is no urgency to merge this or have anything to be fixed.


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@soareschen soareschen marked this pull request as draft March 28, 2022 17:45
@romac romac changed the title Test ordered channel relaying with concurrent relayers Test ordered channel relaying with concurrent relayers Mar 29, 2022
@adizere adizere added the A: blocked Admin: blocked by another (internal/external) issue or PR label Apr 6, 2022
@adizere
Copy link
Member

adizere commented May 2, 2022

Soares: We'll revisit this potentially later. It's a proactive squashing of bugs for ICA use-case. WIll probably be useful for v1 release.

@adizere adizere closed this May 2, 2022
@romac romac deleted the soares/ordered-relaying-race branch November 22, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: blocked Admin: blocked by another (internal/external) issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test ordered channel packet relaying correctness in the presence of concurrent relayers
2 participants