Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test clear_packet behavior #1881

Merged
merged 9 commits into from
Feb 16, 2022
Merged

Test clear_packet behavior #1881

merged 9 commits into from
Feb 16, 2022

Conversation

soareschen
Copy link
Contributor

@soareschen soareschen commented Feb 16, 2022

This adds integration test for #1879.

Description


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@soareschen soareschen changed the title Test on ordered channel relaying behavior Test clear_packet behavior Feb 16, 2022
@soareschen soareschen marked this pull request as ready for review February 16, 2022 10:10
Copy link
Member

@romac romac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet 🥇

@romac romac merged commit 202ae4e into master Feb 16, 2022
@romac romac deleted the soares/ordered-channel-test branch February 16, 2022 10:45
Copy link
Member

@adizere adizere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Soares, this is fantastic work!

(I only had a chance to review it more closely now.)

)?;

// Wallet on chain B should only receive the second IBC transfer
chains.node_b.chain_driver().assert_eventual_wallet_amount(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is pretty neat being able to capture this advanced case in such a simple way.

hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
* Cleaned up clear_packets logic from RelayPath.

* changelog

* Test on ordered channel relaying behavior

* Test now shows correct behavior

* Change test names to target clear_packet test

* Add tools/ directory to CI trigger

* Add tools/ directory to integration-test CI trigger

Co-authored-by: Adi Seredinschi <adi@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants