Unify error message casing #1841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adizere
approved these changes
Feb 3, 2022
There was a problem hiding this comment.
Love it! Left two questions, feel free to merge.
I will do a bit of noise by tagging the whole core team here, as an unofficial signal that we're adopting lower-cases in log messages throughout the codebase. @hu55a1n1 @mzabaluev @seanchen1991 @soareschen.
mzabaluev
reviewed
Feb 3, 2022
romac
commented
Feb 4, 2022
romac
commented
Feb 4, 2022
mzabaluev
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Start error message with a lower case letter everywhere.
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.