Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MSRV to 1.56 #1516

Merged
merged 8 commits into from
Oct 28, 2021
Merged

Update MSRV to 1.56 #1516

merged 8 commits into from
Oct 28, 2021

Conversation

romac
Copy link
Member

@romac romac commented Oct 28, 2021 •
edited
Loading

Closes: #1519

Note: MSRV = Minimum Supported Rust Version

For contributor use:

  • Added a changelog entry, using unclog.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

adizere
adizere approved these changes Oct 28, 2021
View reviewed changes
Copy link
Member

@adizere adizere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand all the changes, in particular around rust-toolchain.toml and the edition. Approving but copying @soareschen since he may have more informed opinions on reviewing this!

Just a question for my understanding: It seems edition 2018 still works, is it advisable (or good practice) to change to 2021?

In this commit (b6d6bdb) we updated to 1.56, but left edition unchanged, and it compiled.

@romac
Copy link
Member Author

romac commented Oct 28, 2021

Since the minimum Rust version we support is 1.56, we can now opt-in into the 2021 edition which unlocks some new features: https://blog.rust-lang.org/2021/10/21/Rust-1.56.0.html#rust-2021

The rust-toolchain change just makes sure that people have the clippy and rustfmt components installed in their Rust toolchain.

@romac romac merged commit fc4172a into master Oct 28, 2021
@romac romac deleted the romac/msrv branch October 28, 2021 11:52
@romac romac mentioned this pull request Oct 28, 2021
Closed
14 tasks
@adizere adizere mentioned this pull request Nov 15, 2021
Merged
5 tasks
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@romac
Update MSRV to 1.56 (informalsystems#1516)
8942bd4 
* Switch to `rust-toolchain`.toml

* Add `rust-version` field to all packages to specify MSRV

* Enable all features on docs.rs for modules and relayer libraries

* Update MSRV in README

* Update edition to 2021

* Add `TryFrom`, `TryInto` and `FromIterator` to the prelude to match the 2021 std prelude

* Add changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmanian zmanian zmanian approved these changes

@adizere adizere adizere approved these changes

@ancazamfir ancazamfir Awaiting requested review from ancazamfir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update MSRV to Rust 1.56 and use the 2021 edition
3 participants
@romac @zmanian @adizere