Upgrade proto to ibc-go v1.2 and sdk v0.44 #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adizere
changed the title
8 tasks
ancazamfir
requested review from
romac,
soareschen and
hu55a1n1
and removed request for
ancazamfir
5 tasks
ancazamfir
reviewed
Nov 3, 2021
relayer/src/chain/cosmos.rs
Outdated
Comment on lines
1478
to
1489
| // TODO: Request should be a domain type | ||
| let version_compatible_request = if self.version_specs.ibc_go_pre_v1_2() { | ||
| // if < v1.2 overwrite with empty `packet_commitment_sequences` field | ||
| let mut r = request; | ||
| r.packet_commitment_sequences = vec![]; | ||
| r | ||
| } else { | ||
| // if >= v1.2 leave the request unchanged | ||
| request | ||
| }; | ||
|
|
||
| let request = tonic::Request::new(version_compatible_request); |
There was a problem hiding this comment.
After looking more into this, doing more tests, reading on proto, I think we should undo this change. See unknowns.
It turns out unknown fields are just dropped or retained as unknown fields (depending on the proto and parser versions) but the parser should still be able to work with all fields present in the old proto version. I tested without these checks with old gaia versions and all looks good.
(fwiw for ibc-rs/modules and basecoin, prost drops unknown fields iiuc)
Would still keep the versions_specs boilerplate to deal with incompatibilities not handled by proto, e.g. chann-init with >64 len portsPortId-s where we need to check the version of the chain potentially receiving the chann-try.
5 tasks
5 tasks
6 tasks
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
* Regenerated proto files with ibc-go v1.2 and sdk v0.44 * Make the code compile * Restructure packet queries * Added support to fetch chain version in bootstrap() * Updated validation for port identifier (informalsystems#1523) * Fix for compat. packet_commitment_sequences with ibc-go pre v1.2 * Fixed tests, better comments * Re-generated using most recent commits. * Fix bootstrap() unwraps in CLIs. * Changelog * Add log traces for version parsing * FMT * More test fixes * Add commitment sequences to query ack request * Remove version compatibility check in query_packet_acknowledgements Co-authored-by: Anca Zamfir <zamfiranca@gmail.com> Co-authored-by: Valery Litvin <litvintech@gmail.com> Co-authored-by: Romain Ruetschi <romain@informal.systems>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1408
Changes introduced by this PR:
Proto files
Proto files are even with ibc-go v1.2.2 and SDK v0.44.3.
Compatibility
Hermes is fully compatible with ibc-go v1.2 and SDK v0.44 with one exception:
Bootstrap method semantics
The method
CosmosSdk::bootstrapcan potentially return with error if it fails to query the SDK version from the full node (via gRPCGetNodeInfoRequest).bootstrapchanged: this method returns successfully only if the the full node is up-and-running and Hermes obtains a successful response toGetNodeInfoRequest.bootstrapwere more lax and this method returned Ok even if the full node was entirely inaccessible.bootstrap(..).unwrap()calls. These unwraps would result in a panic when the full node is inaccessible.TODOs
For contributor use:
unclog.docs/) and code comments.Files changedin the Github PR explorer.