Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration tools #140

Merged
merged 16 commits into from
Jul 14, 2020
Merged

integration tools #140

merged 16 commits into from
Jul 14, 2020

Conversation

greg-szabo
Copy link
Member

@greg-szabo greg-szabo commented Jul 10, 2020

Closes: #32 Well, it gives us a framework but we should keep #32 open for the actual integration tests that we still have to implement.

Description

This is a set of scripts and GitHub Actions that implement a framework for integration testing for IBC and the relayer.

  • Script to create gaiad nodes docker image for the "two-chainz" relayer
  • Script to create a simd node docker image with existing IBC state on chain
  • Genesis.json (and simd configuration) with initial IBC state filled (courtesy of @ebuchman in add chain data #133, expanded with more state)

There is a new "integration-test" GitHub Action that sets up two chains and the relayer from source and tries to query things. Currently, it's failing because we're still implementing queries. This is fine, as soon as we have something to query, we can improve it. Or we can disable it for now...

The docker images are created and uploaded from dev machines, they are not automated. The images are used for development work and they change rapidly as we implement new features and need new tests... But the scripts are important to share, so we can easily create/recreate Docker images with the fresh code.


For contributor use:

  • Unit tests written
  • Added test to CI if applicable
  • Updated CHANGELOG_PENDING.md
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments
  • Re-reviewed Files changed in the Github PR explorer

@greg-szabo greg-szabo mentioned this pull request Jul 11, 2020
6 tasks
@greg-szabo greg-szabo changed the title Greg/ci integration tools Jul 11, 2020
Copy link
Member

@ebuchman ebuchman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start thanks Greg!

ci/simapp/README.md Outdated Show resolved Hide resolved
@ebuchman ebuchman merged commit f5469f1 into master Jul 14, 2020
@ebuchman ebuchman deleted the greg/ci branch July 14, 2020 01:34
@adizere adizere linked an issue Jul 21, 2020 that may be closed by this pull request
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
* Docker images for gaia chains

* Added GitHub Actions to run integration test with two chains

* Relayer GitHub Actions configuration and testing

* Integration test fixes

* Integration fixes

* HEIGHT fix

* Separated cargo runs

* Another test for build and config

* Moved chain_a creation into one shell space

* Fix for chain_b config

* Integration tests fail because they don't exist

* Trying test command

* Docs update

* Simapp and new genesis

* Added pruning=nothing for simd config

* Update ci/simapp/README.md

Co-authored-by: Ethan Buchman <ethan@coinculture.info>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants