Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on sled #1360

Merged
merged 2 commits into from
Sep 17, 2021
Merged

Remove dependency on sled #1360

merged 2 commits into from
Sep 17, 2021

Conversation

romac
Copy link
Member

@romac romac commented Sep 16, 2021

Closes: #1351

Description

Remove the dependency on sled.

Caveat

For reasons which are unclear, this currently still pulls in sled even though the corresponding feature of tendermint-light-client is disabled.

I am trying to fix this by making the lightstore-sled feature disabled by default in tendermint-rs: informalsystems/tendermint-rs#977

Once the tendermint-rs is merged, the dependency on sled will disappear.


For contributor use:

  • Added a changelog entry, using unclog.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@romac romac marked this pull request as ready for review September 17, 2021 10:48
Copy link
Member

@adizere adizere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@romac romac merged commit ad085e7 into master Sep 17, 2021
@romac romac deleted the romac/remove-sled branch September 17, 2021 14:02
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
* Remove dependency on `sled`

* Update Cargo.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependency on sled
2 participants