Domain type & semantic validation of max_tx_size and max_num_msg config options
#1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romac
changed the title
max_tx_size and max_num_msg config options
hu55a1n1
reviewed
Jul 29, 2021
hu55a1n1
reviewed
Jul 29, 2021
adizere
commented
Jul 29, 2021
| impl Default for MaxMsgNum { | ||
| fn default() -> Self { | ||
| Self(DEFAULT_MAX_MSG_NUM) | ||
| Self(Self::DEFAULT) |
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
…config options (informalsystems#1246) * Fix for informalsystems#1245 * Split out params semantic validation from health check * Fixup changelog entry * Add .changelog entry * Extract max fraction of genesis block max size into a consant * Doc comments for constants * Harmonize error messages * Improve error message layout * Comments & output consistent with parameters * Final aestetic change Co-authored-by: Romain Ruetschi <romain@informal.systems>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1245
Description
For contributor use:
unclog.docs/) and code comments.Files changedin the Github PR explorer.