Exit when worker detects expired client, remove event decoding trace #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adizere
approved these changes
Jun 1, 2021
relayer/src/worker/client.rs
Outdated
| @@ -56,7 +56,7 @@ impl ClientWorker { | |||
| // Run client refresh, exit only if expired or frozen | |||
| if let Err(e @ ForeignClientError::ExpiredOrFrozen(..)) = client.refresh() { | |||
| error!("failed to refresh client '{}': {}", client, e); | |||
| continue; | |||
| return Err(Box::new(e)); | |||
There was a problem hiding this comment.
Just a thought: Would it make more sense to return with an Ok(()) here? I think it might be less confusing for the caller if we distinguish between returning with an Error (in which case the worker could retry for specific error), and returning with Ok (in this case the worker finished its job).
Suggested change
| return Err(Box::new(e)); | |
| return Ok(()); |
There was a problem hiding this comment.
Yeah I think return Ok is fine, as we already print the error before exiting (though perhaps it should be a warning then?)
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
…nformalsystems#1023) * Exit when worker detects expired client, remove event decoding trace * Provide worker's name when worker aborts * Exit client worker without error when client is expired or frozen * Remove unused import * Changelog Co-authored-by: Romain Ruetschi <romain@informal.systems> Co-authored-by: Adi Seredinschi <adi@informal.systems>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1022
Description
While debugging an issue on akashnet, noticed that client workers don't exit when states are expired.
Also the trace for undecoded events is still super annoying so let's remove it.
For contributor use:
docs/) and code comments.Files changedin the Github PR explorer.