-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prototype implementation of CometMock #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSalopek
approved these changes
May 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome!
I hope this gets used soon, it will greatly reduce the runtimes of e2e tests and allows us to run non-determinism tests on basically every commit to figure out if there are any state-breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes cosmos/interchain-security#917
Description
This PR implements a prototype for CometMock, a Go implementation of Tendermock https://github.com/informalsystems/tendermock.
Its goal is to replace Tendermint in End-To-End tests.
It provides the essential RPC functions that Tendermint provides,
and itself calls an application via ABCI over grpc.
Structure of the implementation
The files are split into three parts:
or to SetSigners for the next block
Implemented functionality
CometMock is essentially on feature parity with the old implementation of Tendermock.
It can:
Many responses are not faithful yet, i.e. they may return results with fields that are empty even when CometBFT behaviour would be to return information in those fields. These will be included as they are necessary for tests.