2494 - Fix legend URL behavior when selectable attribute is true #2824
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the details for making this change. What existing problem does the pull request solve?
Problem
While setting the
selectable
attribute in a bar (/any other) chart, the legend icon acts as a URL.Setting up the chart
selectable
attribute to false (or adding pointer-events : none for the anchor tag in DOM) prevents the chart legend from acting as a URL but does not retain the highlight effect on clicking each of the chart slices.Solution
Added
pointer-events: none;
toswatch
tag, so all clicks on theswatch
element will be passed to a parentchart-legend-item
element.Related github/jira issue (required):
Closes #2494
Steps necessary to review your pull request (required):
http://localhost:4300/ids-bar-chart/selectable.html
nvm i && nvm use && npm i && npm run start
Included in this Pull Request: