Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2494 - Fix legend URL behavior when selectable attribute is true #2824

Closed
wants to merge 10 commits into from

Conversation

gurov
Copy link
Collaborator

@gurov gurov commented Sep 12, 2024

Explain the details for making this change. What existing problem does the pull request solve?

Problem
While setting the selectable attribute in a bar (/any other) chart, the legend icon acts as a URL.

Setting up the chart selectable attribute to false (or adding pointer-events : none for the anchor tag in DOM) prevents the chart legend from acting as a URL but does not retain the highlight effect on clicking each of the chart slices.

Solution
Added pointer-events: none; to swatch tag, so all clicks on the swatch element will be passed to a parent chart-legend-item element.

Related github/jira issue (required):

Closes #2494

Steps necessary to review your pull request (required):

http://localhost:4300/ids-bar-chart/selectable.html

Included in this Pull Request:

  • Some documentation for the feature.
  • A test for the bug or feature.
  • A note to the change log.

@gurov gurov requested a review from a team as a code owner September 12, 2024 11:53
@gurov gurov changed the title 2494 Fix legend URL behavior when selectable attribute is true #2494 Fix legend URL behavior when selectable attribute is true Sep 12, 2024
@gurov gurov changed the title #2494 Fix legend URL behavior when selectable attribute is true 2494 - Fix legend URL behavior when selectable attribute is true Sep 12, 2024
…dable-area-toggle-button-fix-angular

2730 - ids-expandable-area toggle-button fix for angular
tmcconechy
tmcconechy previously approved these changes Sep 12, 2024
Copy link
Member

@tmcconechy tmcconechy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gurov looks like a good solution. The only thing: Can you please put the change log in a new 1.5.1 section since 1.5.0 is already released. If you sync with main i think that the new section will be there https://github.com/infor-design/enterprise-wc/blob/main/doc/CHANGELOG.md#151

(but should add it in a fixes section under)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IdsBarChart: Legend acts as an URL with selectable attribute set as true
3 participants