Adding the missing parameters for creating the next available Subnet in a Address block #6
Conversation
…in a Address block
venkat-iblox
changed the title
| @@ -7,6 +7,7 @@ package address_block | |||
|
|
|||
| import ( | |||
| "context" | |||
| "github.com/go-openapi/swag" | |||
There was a problem hiding this comment.
You might want to follow the existing pattern and move this one to the next block.
| // query param cidr | ||
| var qrCidr int32 | ||
|
|
||
| if o.Cidr != nil { |
There was a problem hiding this comment.
Isn't this if pointless? Same comment applies to all added parameters.
There was a problem hiding this comment.
True. But this is generated code, so I left it as is
| var qrComment string | ||
|
|
||
| if o.Comment != nil { | ||
| qrComment = *o.Comment | ||
| } | ||
| qComment := qrComment | ||
| if qComment != "" { |
There was a problem hiding this comment.
Do we really need two temporary variables to handle a string?
There was a problem hiding this comment.
Yes, we don't need it. But this is generated code, so I left it as is
| } | ||
| } | ||
| } | ||
|
|
||
| if len(res) > 0 { | ||
| return errors.CompositeValidationError(res...) | ||
| } |
There was a problem hiding this comment.
Are we supposed to accumulate all the errors within res instead of bailing out on the first one?
There was a problem hiding this comment.
We should. But this is generated code, so I left it as is
I should have added this info |
venkat-iblox
merged commit 660297e
into
infobloxopen:inheritance_sources
To support the creation of the Next Available Subnet in an Address Block. The added Params are sent in QueryParams and are used in the creation.