Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for a TLS-enabled Docker daemon #910

Closed
wants to merge 6 commits into from
Closed

Added support for a TLS-enabled Docker daemon #910

wants to merge 6 commits into from

Conversation

AntonBazhal
Copy link

No description provided.

@sparrc
Copy link
Contributor

sparrc commented Apr 1, 2016

thanks @AntonBazhal for the contribution. We've had some permissions issues with the current docker client library so I'm going to wait for #645 to get fixed before merging this.

@sparrc
Copy link
Contributor

sparrc commented Apr 6, 2016

Hi @AntonBazhal, I'm closing this PR because it will need to be refactored for the new docker plugin, which uses docker's official libraries to gather stats rather than the 3rd-party library that we were using before.

@sparrc sparrc closed this Apr 6, 2016
@sparrc
Copy link
Contributor

sparrc commented Apr 6, 2016

ps: I would be happy to merge if you can refactor to use the new library

@AntonBazhal
Copy link
Author

@sparrc, problem with the new library is that it does not have corresponding NewTLSClient class, thus it is not possible to refactor.

@tripledes
Copy link

@AntonBazhal the newclient() method from the new docker library takes an http.Client as a parameter, so you need to configure the transport layer to use TLS. So it should be possible to refactor your PR. Let me know if I could be of any help.

https://godoc.org/github.com/docker/engine-api/client#NewClient

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants