systemd_units: fix parsing #8381
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending on the environment it may or not may contain unicode characters
|
It fixes this error: |
srebhan
requested changes
Nov 12, 2020
Comment on lines
154
to
157
| // not found or failed units might have a leading asterisk | ||
| if data[0] == "*" { | ||
| data = data[1:] | ||
| } |
There was a problem hiding this comment.
The problem is that we remove things after the length check. There might be cases where you get four fields, but an asterix in the beginning and then end up with only three fields left in data.
How about adding
Suggested change
| // not found or failed units might have a leading asterisk | |
| if data[0] == "*" { | |
| data = data[1:] | |
| } | |
| if strings.HasPrefix(line, "*") { | |
| line = strings.Replace(line, "*", "", 1) | |
| } |
above, directly after the assignment to line (line 148 I think) and before creating data?
Their first field will be an asteric: $ LC_ALL=C systemctl list-units --all --type=service --no-legend accounts-daemon.service loaded active running Accounts Service * acpid.service not-found inactive dead acpid.service alsa-store.service loaded active exited Store Sound Card State * apparmor.service not-found inactive dead apparmor.service audio-off.service loaded active exited Mute audio before suspend audit.service loaded active exited Kernel Auditing
|
Does this also relate to issue #7990? |
ssoroka
approved these changes
Nov 12, 2020
srebhan
approved these changes
Nov 12, 2020
|
this might be resolved now as of #7991 |
|
Yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs: