Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added more performance counters to SqlServer input plugin #8120

Merged
merged 2 commits into from
Sep 24, 2020
Merged

Added more performance counters to SqlServer input plugin #8120

merged 2 commits into from
Sep 24, 2020

Conversation

avinash-nigam
Copy link
Contributor

@avinash-nigam avinash-nigam commented Sep 12, 2020 •
edited
Loading

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@avinash-nigam
Copy link
Contributor Author

@denzilribeiro Could you please review this PR for adding more perf counters to the SqlServer plugin?

denzilribeiro
denzilribeiro approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@denzilribeiro denzilribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - you think "Logical connections" isn't an edge case though?

@avinash-nigam
Copy link
Contributor Author

avinash-nigam commented Sep 18, 2020 •
edited
Loading

Looks good - you think "Logical connections" isn't an edge case though?

We did get a few customers asking for the same, hence including the same

@avinash-nigam
Copy link
Contributor Author

@ssoroka and @reimda - could you please help merge this pull request?

@reimda
Copy link
Contributor

reimda commented Sep 22, 2020

@ssoroka and @reimda - could you please help merge this pull request?

Could you include a link to documentation where these counter names are described, either from Microsoft or go-mssqldb?

@avinash-nigam
Copy link
Contributor Author

avinash-nigam commented Sep 22, 2020 •
edited
Loading

@ssoroka and @reimda - could you please help merge this pull request?

Could you include a link to documentation where these counter names are described, either from Microsoft or go-mssqldb?

@reimda - Yes, here are the Microsoft documentation links for each counter added -

Table Lock Escalations/sec - MSSQL$*:Access Methods
Free pages - MSSQL$*:Buffer Manager
Active Transactions - MSSQL$*:Databases
Log Growths - MSSQL$*:Databases
Logical Connections - MSSQL$*:General Statistics
Distributed Query - MSSQL$*:Exec Statistics
DTC calls - MSSQL$*:Exec Statistics
Query Store CPU usage - SQLServer:Query Store

@avinash-nigam
Copy link
Contributor Author

@reimda - Please let me know if you need further information on these counters before merging the pull request. Thank you!

reimda
reimda suggested changes Sep 23, 2020
View reviewed changes
plugins/inputs/sqlserver/sqlqueriesV2.go
@@ -465,13 +465,19 @@ SET @SqlStatement = @SqlStatement + CAST(N' WHERE (
''Readahead pages/sec'',
''Lazy writes/sec'',
''Checkpoint pages/sec'',
''Free pages'',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you put those documentation links for the counters in the source code, maybe on the line before declaring sqlPerformanceCountersV2? I'm hoping doc links will help out future maintainers who are not as familiar with SQL Server. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you put those documentation links for the counters in the source code, maybe on the line before declaring sqlPerformanceCountersV2? I'm hoping doc links will help out future maintainers who are not as familiar with SQL Server. Thanks!

@reimda Thank you for the prompt review of the changes

@reimda reimda merged commit bb5c65f into influxdata:master Sep 24, 2020
@avinash-nigam avinash-nigam deleted the sqlServerPluginMoreCounters branch October 29, 2020 10:20
@avinash-nigam avinash-nigam mentioned this pull request Dec 8, 2020
Merged
3 tasks
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
@avinash-nigam
Added more performance counters to SqlServer input plugin (influxdata…
bf2578b 
…#8120)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reimda reimda reimda approved these changes

@denzilribeiro denzilribeiro denzilribeiro approved these changes

Assignees
No one assigned
Labels
area/sqlserver
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@avinash-nigam @reimda @denzilribeiro @sjwang90