Deploy telegraf configuration as a "non config" file #7250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anything missing from my side? |
|
@danielnelson is there any procedure for triggering a review? (other than the CLA) |
|
@ssoroka could I request a reviewer for this PR? (not sure if you're organized by topics or it's best effort). Thanks! |
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
veorlo
pushed a commit
to GlobalNOC/telegraf
that referenced
this pull request
May 4, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
Description
This PR fixes #4966, by changing the way
telegraf.confis packaged and deployed:telegraf.confis now packaged astelegraf.conf.sample. This will make package managers compare over the.samplefile instead of the.confone, making it more user friendly since/etc/telegraf.confis usually configured by the user/etc/telegraf/telegraf.confis present on the target system (typical case of a fresh install), the post installation step will copy/etc/telegraf/telegraf.conf.sampleto/etc/telegraf/telegraf.confto have an initial working configurationNotes:
build.pyfile, based on PEP-8 recommendationslinux/amd64rpm/debpackages, I take it it should be similar for the rest since there is a lot of shared code but if I'm missing some scenario please let me knowCHANGELOGmyself, if so please let me knowFeel free to add any suggestion, I was not really familiar with
debrpmpackaging internals, nor withfpm.