-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show default settings in mysql sample config #6484
Conversation
## gather thread state counts from INFORMATION_SCHEMA.PROCESSLIST | ||
gather_process_list = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't this (and others) negatively affect those generating and using the config file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you give an example of what might happen?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes the default/generated config file, so if anyone is relying on these values, telegraf will no longer do what they are expecting. In this case, the process list would no longer be gathered unless manual action is taken on their part, whereas before no action was required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, a newly generated config would be different from a generated config in the previous version. The reason I think this is okay is that previously generated configs will continue to work as before. The default values aren't changing (with the exception of the values in the first comment) they were documented incorrectly.
The sample config now shows the default values. I added new defaults for the perf events since the existing defaults were not usable and the plugin required them to be set.
closes #6444
Required for all PRs: