Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify behaviour of enum processor without default or defined mapping #6301

Merged
merged 4 commits into from
Oct 8, 2019
Merged

Clarify behaviour of enum processor without default or defined mapping #6301

merged 4 commits into from
Oct 8, 2019

Conversation

Woodz
Copy link
Contributor

@Woodz Woodz commented Aug 22, 2019 •
edited
Loading

Resolve: #6291

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

Richard Wise added 2 commits August 22, 2019 09:16
Clarify documentation of enum processor edge case
cab937e 
Add expected behaviour when dest is set, default is unset and value is unrecognised
Resolve: #6291
Add unit test for enum processor
6eb5eac 
Add test for edge case without defined default or defined mapping
@danielnelson
Copy link
Contributor

Thanks, could you run make fmt with Go 1.12 to normalize the indention?

@danielnelson danielnelson added docs Issues related to Telegraf documentation and configuration descriptions feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin labels Aug 23, 2019
@Woodz
Copy link
Contributor Author

Woodz commented Oct 5, 2019

Thanks, could you run make fmt with Go 1.12 to normalize the indention?

Sorry @danielnelson, for using the wrong format earlier and for the delay in rectifying. I have now reformatted as requested

Remove unused local variable
e8330aa 
To match code style requirements of gofmt, replace unused local variable with a wildcard
@danielnelson danielnelson added this to the 1.13.0 milestone Oct 8, 2019
@danielnelson danielnelson merged commit da17d65 into influxdata:master Oct 8, 2019
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
Clarify behaviour of enum processor without default or defined mapping (
436110b 
influxdata#6301)
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
Clarify behaviour of enum processor without default or defined mapping (
caec46f 
influxdata#6301)
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
@danielnelson
Clarify behaviour of enum processor without default or defined mapping (
406e98e 
influxdata#6301)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs Issues related to Telegraf documentation and configuration descriptions feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

Enum documentation is incorrect when value is unknown and dest is set
2 participants
@Woodz @danielnelson