Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added hep protocol support as parser in telegraf #6167

Closed
wants to merge 4 commits into from

Conversation

aqsyonas
Copy link

@aqsyonas aqsyonas commented Jul 25, 2019

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@aqsyonas aqsyonas changed the title Added hep protocol support in as parser in telegraf Added hep protocol support as parser in telegraf Jul 25, 2019
@lmangani
Copy link

For more backstory on the implemented protocol: HEP is an open encapsulation protocol extremely popular in VoIP Applications and natively supported by many platforms such as Kamailio, OpenSIPS, Asterisk, Freeswitch and others.

For more information on HEP and its enabled projects: https://github.com/sipcapture

@danielnelson
Copy link
Contributor

Thanks @aqsyonas and @lmangani, would love to hear more about the specifics of how one would utilize this parser. I'll probably want to setup a testing environment as well, any suggestions for which program I could use that, whichout too much fuss, could generate some interesting data?

@lmangani
Copy link

lmangani commented Jul 29, 2019

Hi @danielnelson thanks for your feedback! We have a HEP generator in NodeJS you can use to pump some data towards the socket. Find it here: https://github.com/sipcapture/hepgen.js

We're available to provide examples and assistance setting up and executing any test ;)

EDIT: The following should work, adjust the TELEGRAF IP and PORT to match the socket:

git clone https://github.com/sipcapture/hepgen.js
cd hepgen.js
npm install
nodejs hepgen.js -s {TELEGRAF_IP} -p {TELEGRAF_PORT} -c ./config/reports_rtp.js

@aqsyonas
Copy link
Author

aqsyonas commented Jul 29, 2019

@danielnelson Thanks, for the reply. I have generated some data using the parser, below stats are from influxdb.

time CLOCK CODEC_PT DELTA DIR DST_PORT EXPECTED_PK JITTER MAX_DELTA MAX_SKEW MEAN_JITTER MEAN_MOS cid dest_ip4 dest_port host node_id node_pw nodename protocol protocol_type_field tsec src_ip4
1564391681515466558 8000 9 19.983 0 51354 1512 0.017 20.024 0.172 0.005 4.032 7k3fq@127.0.0.1_b2b-1 224.9.197.178 0 testServer 2001 myHep 2001 35 35 1564391694 55.66.77.83
1564391684007630125 8000 9 11.983 0 51354 1512 0.011 20.124 0.221 0.305 3.932 7k3fq@127.0.0.1_b2b-1 224.9.197.178 0 testServer 2001 myHep 2001 35 35 1564391694 55.66.77.83
1564391686506494653 8000 9 19.983 0 51354 1512 0.017 20.024 0.172 0.005 4.032 7k3fq@127.0.0.1_b2b-1 224.9.197.178 0 testServer 2001 myHep 2001 35 35 1564391694 55.66.77.83
1564391689007343462 8000 9 11.983 0 51354 1512 0.011 20.124 0.221 0.305 3.932 7k3fq@127.0.0.1_b2b-1 224.9.197.178 0 testServer 2001 myHep 2001 35 35 1564391694 55.66.77.83
1564391691508162941 8000 9 19.983 0 51354 1512 0.017 20.024 0.172 0.005 4.032 7k3fq@127.0.0.1_b2b-1 224.9.197.178 0 testServer 2001 myHep 2001 35 35 1564391694 55.66.77.83

I have just selected a few stats, but Hep protocol does offer feature in-rich information regarding the calls.

Please let me know if that helps.
Br, Aqs.

@srebhan
Copy link
Member

srebhan commented Oct 20, 2021

Hey @aqsyonas are you still interested to getting this parser merged?

@srebhan srebhan self-assigned this Oct 20, 2021
@srebhan srebhan added the plugin/parser 1. Request for new parser plugins 2. Issues/PRs that are related to parser plugins label Oct 20, 2021
@lmangani
Copy link

lmangani commented Oct 20, 2021

@srebhan yes - I'll pick this thread up

@srebhan
Copy link
Member

srebhan commented Oct 20, 2021

@lmangani wonderful! Can you please first rebase the PR on the current master and make sure you don't modify the unrelated plugins/parsers/influx/machine.go? Let me know once you are done and I will give it a review...

@lmangani
Copy link

lmangani commented Oct 20, 2021

@srebhan we will shortly open a new PR with rebased code and refer to this issue - thanks!

@srebhan
Copy link
Member

srebhan commented Oct 21, 2021

When you are ready, please mention the new PR here and close this PR. Feel free to assign me to or request a review for the new PR...

@adubovikov
Copy link

@srebhan sorry for delay. Here is the new one: #10039
This we can close.

@srebhan srebhan closed this Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new plugin plugin/parser 1. Request for new parser plugins 2. Issues/PRs that are related to parser plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants