Add Graphite output #451
Add Graphite output #451
Conversation
titilambert
force-pushed
the
graphite
branch
2 times, most recently
from
5ffac19
to
17f9b93
Compare
| var sampleConfig = ` | ||
| [[outputs.graphite]] | ||
| # TCP raw endpoint for your graphite instance. | ||
| servers = ["mygraphiteserver:2003"] # required |
There was a problem hiding this comment.
could you have this default to localhost:2003?
|
awesome, thanks @titilambert! |
titilambert
force-pushed
the
graphite
branch
from
17f9b93
to
bbcf68e
Compare
| servers = ["mygraphiteserver:2003"] # default "localhost:2003" | ||
| # Prefix metrics name | ||
| prefix = "" # default "" | ||
| # Timeout |
There was a problem hiding this comment.
what are the units of Timeout?
There was a problem hiding this comment.
cool, can you add two things to the comment: 1) unit of the timeout 2) what is the timeout (ie, what is the thing that will timeout)
titilambert
force-pushed
the
graphite
branch
3 times, most recently
from
815b9e9
to
b96dd8c
Compare
titilambert
force-pushed
the
graphite
branch
3 times, most recently
from
4a669ea
to
aaf175e
Compare
|
@sparrc Hello ! |
titilambert
force-pushed
the
graphite
branch
from
aaf175e
to
5b71035
Compare
| var bp []string | ||
| for _, point := range points { | ||
| // Get name | ||
| names := strings.SplitN(point.Name(), "_", 2) |
There was a problem hiding this comment.
Can you explain this part? Are you just parsing out the plugin name? why?
There was a problem hiding this comment.
@sparrc Hello !
I'm trying to find which name have to use to avoid names like myplugin_mymetricname
My use case is with the snmp plugin, I don't want something like snmp_cpu_idle, snmp_cpu_user, ...
Maybe I should add an test about that stuff ?
There was a problem hiding this comment.
Do you mind if we remove that part? it won't be a problem anymore in 0.3.0, as we won't be prepending plugin names to measurement names anymore. So in 0.3.0, you would actually lose part of the field name
There was a problem hiding this comment.
@sparrc Cool ! Do you want I rebase the PR on 0.3.0 branch ?
BTW, do you prefer PR based on 0.3.0 branch ?
There was a problem hiding this comment.
Yes, PR based off 0.3.0 branch would be helpful, thanks!
titilambert
force-pushed
the
graphite
branch
2 times, most recently
from
5c3379d
to
1820238
Compare
|
I close this PR to open a new one based on 0.3.0 |
Hello !
This is a graphite output ! Useful when you want to initiate the migration to InfluxDB :)
TODO: