fix logic in tags/names/fields filtering #3036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust logic in functions responsible for passing metrics (should Field/Name/Tags Pass) in order to be able to process them correctly in case where pass and drop are defined together. Change documentation to reflect this change Create additional tests to cover it.
danielnelson
approved these changes
Jul 21, 2017
vlamug
pushed a commit
to vlamug/telegraf
that referenced
this pull request
Jul 24, 2017
Adjust logic in functions responsible for passing metrics in order to be able to process them correctly in case where pass and drop are defined together.
jeichorn
pushed a commit
to jeichorn/telegraf
that referenced
this pull request
Jul 24, 2017
Adjust logic in functions responsible for passing metrics in order to be able to process them correctly in case where pass and drop are defined together.
maxunt
pushed a commit
that referenced
this pull request
Jun 26, 2018
Adjust logic in functions responsible for passing metrics in order to be able to process them correctly in case where pass and drop are defined together.
hackery
reviewed
Nov 23, 2021
| } | ||
|
|
||
| if f.namePass != nil && f.nameDrop != nil { | ||
| return pass(f) && drop(f) |
There was a problem hiding this comment.
I know it's an old PR, but whenever I look at this code (because the docs aren't specific enough) I find this sequence confusing. The definition of drop(f) means "the drop filter says 'pass'", which inverts the prosaic sense of the code. if pass and drop just doesn't smell good. Would it be clearer to remove the negation inside drop , and use these?
return pass(f) && ! drop(f)
return pass(f)
return ! drop(f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR is the result of #2860 discussion/issue.
shouldFieldPassandshouldNamePass.Required for all PRs: