-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve redis input documentation #2708
Improve redis input documentation #2708
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I have two optional suggestions that would make it even better:
- I think we should sort the list of fields
- Add field types
Let me know if you are interested in doing these, either way I'll merge it.
Hey, Thank you for the suggestions. I also thought about sorting them alphabetically, but came to the conclusion to arrange them by context - they are actually arranged in categories: Server, Clients, Memory, Persistance, Stats, Replication, CPU, Cluster. This is the order in which Redis returns them too. Maybe if I add an empty line so that the grouping is visible it would be better. I agree about the field types and will add them tomorrow. |
Can you add it to the CHANGELOG? |
Awesome, thanks so much for this! |
Required for all PRs:
#2706