Add minimal documentation to the diskio plugin #2296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PierreF
reviewed
Jan 20, 2017
| - read_time (integer, miliseconds) | ||
| - write_time (integer, miliseconds) | ||
| - io_time (integer, miliseconds) | ||
| - iops_in_progress (integer, miliseconds) (since #2037, not yet in STABLE) |
There was a problem hiding this comment.
iops_in_progress is not milliseconds. It just a count of operation currently in progress.
Also milLiseconds :) (missing a l)
There was a problem hiding this comment.
Fixed, thanks. I only have STABLE installed, so unable to test iops_in_progress.
|
cool, thanks! |
njwhite
pushed a commit
to njwhite/telegraf
that referenced
this pull request
Jan 31, 2017
* Add documentation to diskio plugin * Update spelling, fix iops_in_progress unit
mlindes
pushed a commit
to Comcast/telegraf
that referenced
this pull request
Feb 6, 2017
* Add documentation to diskio plugin * Update spelling, fix iops_in_progress unit
maxunt
pushed a commit
that referenced
this pull request
Jun 26, 2018
* Add documentation to diskio plugin * Update spelling, fix iops_in_progress unit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't find any docs about the diskio plugin, so I did some research and wrote it myself. I think this might be helpful for others. I only checked validity of the timing unit (miliseconds) in Linux and FreeBSD, as I only have access to those platforms.
Required for all PRs: