Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added amqp output #200

Closed
wants to merge 2 commits into from
Closed

Added amqp output #200

wants to merge 2 commits into from

Conversation

ekini
Copy link
Contributor

@ekini ekini commented Sep 15, 2015

Please, review my amqp output plugin.

t.Skip("Skipping integration test in short mode")
}

var url = "amqp://" + testutil.GetLocalHost() + ":5672/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you are following the form of the kafka output plugin here. In the case of kafka, we've added a kafka broker to the scripts/docker-compose.yml file that the test is connecting to in long mode. I'm not very familiar with AMQP, but is there a similar machine that you could add to the dockerfile? Would a rabbitmq docker container work? I think something like this should work:

rabbitmq:
    image: rabbitmq:3-management
    hostname: docker_rabbit
    ports:
        - "15672:15672"
        - "5672:5672"

see long unit tests section of readme for more details: https://github.com/influxdb/telegraf/blob/master/CONTRIBUTING.md#execute-long-tests

@sparrc
Copy link
Contributor

sparrc commented Sep 15, 2015

Could you write a short README for this? See #177

@sparrc
Copy link
Contributor

sparrc commented Sep 15, 2015

This looks great! Thank you very much! Please just address the comments that I've left and I can merge it 👍

@ekini
Copy link
Contributor Author

ekini commented Sep 16, 2015

Thanks for feedback, Cameron! I've corrected typos and added README, but I have one conflict now.
I can do a rebase, but I'm not sure what will happen on github after that.

@sparrc sparrc closed this in d979ee5 Sep 16, 2015
@sparrc
Copy link
Contributor

sparrc commented Sep 16, 2015

@ekini thanks much for your contribution! I made some tweaks to the documentation and changed the default RoutingTag to "host" instead of "dc", because I thought it would be better to use a tag that is defined by default.

I liked that idea so I also added that same functionality to the Kafka output, since that was just hardcoded to use "host" before.

@pdyba
Copy link

pdyba commented Jan 6, 2016

Is it possible to use SSL/Certificates with rabbit.output ?
I did not find appropriate information in docs and in code it self (I am a python developer so I could be wrong :) ) ?
Is there a chance that it will be added in next version ?

@ekini
Copy link
Contributor Author

ekini commented Jan 8, 2016 via email

@ekini
Copy link
Contributor Author

ekini commented Jan 16, 2016

@pdyba Please, see #536

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants