Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
This makes sure that all redis metrics are present without having to use a hard-coded list of what metrics to pull in.
Fixes #1685
I did opt for skipping some stuff, such as most of the "server" section, with the exception of 2 metrics. Most of the fields in this section aren't metrics, but server info. Also skipped any "*_human" field since each has a more accurate field available.
For the fields that were being renamed, I kept the renaming behavior.
I also added a
rdb_last_save_time_elapsed
metric which is calculated usingrdb_last_save_time
, which is an absolute timestamp, and the current time.Influxdb doesn't support
select time - rdb_last_save_time
, so without this, there's no way to tell how long ago the last save was.