Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing redis metrics #1689

Merged
merged 1 commit into from
Aug 31, 2016
Merged

add missing redis metrics #1689

merged 1 commit into from
Aug 31, 2016

Conversation

phemmer
Copy link
Contributor

@phemmer phemmer commented Aug 31, 2016

Required for all PRs:

  • CHANGELOG.md updated (we recommend not updating this until the PR has been approved by a maintainer)
  • Sign CLA (if not already signed)

This makes sure that all redis metrics are present without having to use a hard-coded list of what metrics to pull in.
Fixes #1685

I did opt for skipping some stuff, such as most of the "server" section, with the exception of 2 metrics. Most of the fields in this section aren't metrics, but server info. Also skipped any "*_human" field since each has a more accurate field available.

For the fields that were being renamed, I kept the renaming behavior.

I also added a rdb_last_save_time_elapsed metric which is calculated using rdb_last_save_time, which is an absolute timestamp, and the current time.
Influxdb doesn't support select time - rdb_last_save_time, so without this, there's no way to tell how long ago the last save was.

This makes sure that all redis metrics are present without having to use a hard-coded list of what metrics to pull in.
@sparrc
Copy link
Contributor

sparrc commented Aug 31, 2016

thanks @phemmer

@sparrc sparrc merged commit a8f9eb2 into influxdata:master Aug 31, 2016
@phemmer phemmer deleted the more-redis-metrics branch August 31, 2016 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants