Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.statsd): Allow reporting sets and timings count as floats #15853

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

calind
Copy link
Contributor

@calind calind commented Sep 6, 2024

Summary

Currently, only counters and gauges can be reported as floats. This PR adds support for sets and histogram count fields. This is useful in InfluxDB, where mixed data like floats and ints cannot be grouped.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #15852

@telegraf-tiger telegraf-tiger bot added area/statsd feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Sep 6, 2024
@calind calind force-pushed the master branch 3 times, most recently from 4a02162 to 68ae213 Compare September 9, 2024 12:39
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @calind! Just two small comments from my side...

plugins/inputs/statsd/statsd.go Outdated Show resolved Hide resolved
plugins/inputs/statsd/statsd.go Outdated Show resolved Hide resolved
@srebhan srebhan self-assigned this Sep 9, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update and your work @calind!

@telegraf-tiger
Copy link
Contributor

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Sep 10, 2024
@srebhan srebhan assigned DStrand1 and unassigned srebhan Sep 10, 2024
@DStrand1 DStrand1 merged commit 5d996ac into influxdata:master Sep 12, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.33.0 milestone Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/statsd feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StatsD with float_counters should send timings and sets counts as float
3 participants