Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis input enhancement #1387

Merged
merged 1 commit into from
Jul 14, 2016
Merged

Redis input enhancement #1387

merged 1 commit into from
Jul 14, 2016

Conversation

burdandrei
Copy link
Contributor

Required for all PRs:

  • [V] Sign CLA (if not already signed)
  • [V] README.md updated (if adding a new plugin)

master_last_io_seconds_ago added
role tag renamed to replication_role

@burdandrei
Copy link
Contributor Author

I propose to rename role tag to replication_role, cause now it just overwrites global role tag.
Example - i got environment in AWS with tags "AutoscalingGroup,app,role" meaning server role in application. I got "app=api, role=web", "app=api, role=cache". Chef is adding these tags as global tags. Means if i got couple of cache servers i receive now role=master and role=slave, but it's not what i need.

I think replication_role tag reflects the real redis related role.

@sparrc
Copy link
Contributor

sparrc commented Jun 19, 2016

where exactly is your global "role" tag coming from? And would this problem affect other users?

@burdandrei
Copy link
Contributor Author

burdandrei commented Jun 19, 2016

My global role is coming from AWS tags,
i think other users are using role tag to tag their instances by role too.

@kuchin
Copy link

kuchin commented Jun 20, 2016

+1

1 similar comment
@l13t
Copy link

l13t commented Jun 20, 2016

+1

@sparrc
Copy link
Contributor

sparrc commented Jun 23, 2016

please rebase your changes and put a very clear **Breaking Change**: redis input plugin notice in the v1.0 changelog.

master_last_io_seconds_ago added
role tag renamed to replication_role
@burdandrei
Copy link
Contributor Author

@sparrc done!

@sparrc sparrc merged commit 97d92bb into influxdata:master Jul 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants