Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(parsers.binary): Fix binary parser example in README.md #13547

Merged
merged 1 commit into from
Jul 5, 2023
Merged

docs(parsers.binary): Fix binary parser example in README.md #13547

merged 1 commit into from
Jul 5, 2023

Conversation

trsnx
Copy link
Contributor

@trsnx trsnx commented Jul 4, 2023

Required for all PRs

Fixed syntax error in README.md of binary parser

@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Jul 4, 2023

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/parser 1. Request for new parser plugins 2. Issues/PRs that are related to parser plugins labels Jul 4, 2023
@trsnx
Copy link
Contributor Author

trsnx commented Jul 4, 2023

!signed-cla

srebhan
srebhan approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care @trsnx!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jul 5, 2023
@srebhan srebhan changed the title fix(parsers.binary): Fix binary parser example in README.md docs(parsers.binary): Fix binary parser example in README.md Jul 5, 2023
@srebhan srebhan added the docs Issues related to Telegraf documentation and configuration descriptions label Jul 5, 2023
@powersj powersj merged commit 10c081d into influxdata:master Jul 5, 2023
powersj pushed a commit to powersj/telegraf that referenced this pull request Jul 5, 2023
@trsnx @powersj
fix(parsers.binary): Fix binary parser example in README.md (influxda…
46ee83f 
…ta#13547)
powersj pushed a commit that referenced this pull request Jul 10, 2023
@trsnx @powersj
fix(parsers.binary): Fix binary parser example in README.md (#13547)
98d814e 
(cherry picked from commit 10c081d)
@srebhan srebhan added this to the v1.27.2 milestone Jul 10, 2023
@p-linnane p-linnane mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powersj powersj powersj approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@powersj powersj

Labels
docs Issues related to Telegraf documentation and configuration descriptions fix pr to fix corresponding bug plugin/parser 1. Request for new parser plugins 2. Issues/PRs that are related to parser plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.27.2
Development

Successfully merging this pull request may close these issues.
3 participants
@trsnx @powersj @srebhan