Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.modbus): Fix optimization of overlapping requests and add warning #13486

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Jun 23, 2023

Currently the max_insert optimization cannot handle overlapping requests if e.g. requesting address 100 of type INT64 (equals 4 registers) is followed by a field with address 102. This PR fixes the optimization but warns the user about the overlap as this is only seldom a valid use-case.

@telegraf-tiger telegraf-tiger bot added area/modbus fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jun 23, 2023
@srebhan srebhan changed the title fix(inputs.modbus): Fix optimization of overlapping requests and add … fix(inputs.modbus): Fix optimization of overlapping requests and add warning Jun 23, 2023
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jun 23, 2023
@powersj powersj merged commit 56aac4f into influxdata:master Jun 23, 2023
powersj pushed a commit to powersj/telegraf that referenced this pull request Jul 5, 2023
powersj pushed a commit that referenced this pull request Jul 10, 2023
@srebhan srebhan added this to the v1.27.2 milestone Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/modbus fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants