Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: migrate kafka to testcontainers #11206

Merged
merged 2 commits into from
Jun 2, 2022
Merged

test: migrate kafka to testcontainers #11206

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8de982e
test: migrate kafka to testcontainers
powersj May 27, 2022
816c73e
more
powersj May 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 53 additions & 10 deletions plugins/outputs/kafka/kafka_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,15 @@
package kafka

import (
"context"
"fmt"
"testing"
"time"

"github.com/Shopify/sarama"
"github.com/stretchr/testify/require"
"github.com/testcontainers/testcontainers-go"
"github.com/testcontainers/testcontainers-go/wait"

"github.com/influxdata/telegraf"
"github.com/influxdata/telegraf/metric"
Expand All @@ -23,7 +27,54 @@ func TestConnectAndWriteIntegration(t *testing.T) {
t.Skip("Skipping integration test in short mode")
}

brokers := []string{testutil.GetLocalHost() + ":9092"}
ctx := context.Background()
networkName := "kafka-test-network"
net, err := testcontainers.GenericNetwork(ctx, testcontainers.GenericNetworkRequest{
NetworkRequest: testcontainers.NetworkRequest{
Name: networkName,
Attachable: true,
CheckDuplicate: true,
},
})
require.NoError(t, err)
defer func() {
require.NoError(t, net.Remove(ctx), "terminating network failed")
}()

zookeeper := testutil.Container{
Image: "wurstmeister/zookeeper",
ExposedPorts: []string{"2181:2181"},
Networks: []string{networkName},
WaitingFor: wait.ForLog("binding to port"),
Name: "telegraf-test-zookeeper",
}
err = zookeeper.Start()
require.NoError(t, err, "failed to start container")
defer func() {
require.NoError(t, zookeeper.Terminate(), "terminating container failed")
}()

container := testutil.Container{
Image: "wurstmeister/kafka",
ExposedPorts: []string{"9092:9092"},
Env: map[string]string{
"KAFKA_ADVERTISED_HOST_NAME": "localhost",
"KAFKA_ADVERTISED_PORT": "9092",
"KAFKA_ZOOKEEPER_CONNECT": fmt.Sprintf("telegraf-test-zookeeper:%s", zookeeper.Ports["2181"]),
},
Networks: []string{networkName},
WaitingFor: wait.ForLog("[KafkaServer id=1001] started"),
}
err = container.Start()
require.NoError(t, err, "failed to start container")
defer func() {
require.NoError(t, container.Terminate(), "terminating container failed")
}()

brokers := []string{
fmt.Sprintf("%s:%s", container.Address, container.Ports["9092"]),
}

s, _ := serializers.NewInfluxSerializer()
k := &Kafka{
Brokers: brokers,
Expand All @@ -33,7 +84,7 @@ func TestConnectAndWriteIntegration(t *testing.T) {
}

// Verify that we can connect to the Kafka broker
err := k.Init()
err = k.Init()
require.NoError(t, err)
err = k.Connect()
require.NoError(t, err)
Expand All @@ -45,10 +96,6 @@ func TestConnectAndWriteIntegration(t *testing.T) {
}

func TestTopicSuffixesIntegration(t *testing.T) {
if testing.Short() {
t.Skip("Skipping integration test in short mode")
}

topic := "Test"

m := testutil.TestMetric(1)
Expand Down Expand Up @@ -92,10 +139,6 @@ func TestTopicSuffixesIntegration(t *testing.T) {
}

func TestValidateTopicSuffixMethodIntegration(t *testing.T) {
if testing.Short() {
t.Skip("Skipping integration test in short mode")
}

err := ValidateTopicSuffixMethod("invalid_topic_suffix_method")
require.Error(t, err, "Topic suffix method used should be invalid.")

Expand Down