Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to filter by metric tags #103

Closed
wants to merge 7 commits into from
Closed

Add the ability to filter by metric tags #103

wants to merge 7 commits into from

Commits on Aug 10, 2015

  1. ShouldPass needs to know the tags being used

    @srfraser
    srfraser committed Aug 10, 2015
    Configuration menu
    Copy the full SHA
    3192d2c View commit details
    Browse the repository at this point in the history

  2. Modify ShouldPass so that it checks the tags of a metric, if configured. 

    A plugin can have 'tagpass' and 'tagdrop' subsections:

[disk.tagpass]

And tagname = array lists of things to filter by:

fstype = [ "ext4", "xfs" ]
path = [ "/", /opt", "/home" ]

[disk.tagdrop]
path = [ "/" ]
    @srfraser
    srfraser committed Aug 10, 2015
    Configuration menu
    Copy the full SHA
    954ed79 View commit details
    Browse the repository at this point in the history

  3. tag filtering description added

    @srfraser
    srfraser committed Aug 10, 2015
    Configuration menu
    Copy the full SHA
    86ac897 View commit details
    Browse the repository at this point in the history

  4. to filter by filesystem type, we need to pass that up the chain

    @srfraser
    srfraser committed Aug 10, 2015
    Configuration menu
    Copy the full SHA
    d5cca82 View commit details
    Browse the repository at this point in the history

  5. Ensure tests pass now that we're passing fstype around

    @srfraser
    srfraser committed Aug 10, 2015
    Configuration menu
    Copy the full SHA
    e907055 View commit details
    Browse the repository at this point in the history

  6. go fmt checks

    @srfraser
    srfraser committed Aug 10, 2015
    Configuration menu
    Copy the full SHA
    0ceebc6 View commit details
    Browse the repository at this point in the history

  7. Rework the example configuration snippets

    @srfraser
    srfraser committed Aug 10, 2015
    Configuration menu
    Copy the full SHA
    e7b86be View commit details
    Browse the repository at this point in the history