Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External processor plugin - configuration not applied #8272

Closed
a-bali opened this issue Oct 15, 2020 · 2 comments · Fixed by #8274
Closed

External processor plugin - configuration not applied #8272

a-bali opened this issue Oct 15, 2020 · 2 comments · Fixed by #8274
Labels
area/execd Issues related to execd or plugins that would be better suited to be used through execd bug unexpected problem or unintended behavior

Comments

@a-bali
Copy link
Contributor

a-bali commented Oct 15, 2020

This is a reopen of #8153 with some more details. Applies to current version as of today.

I have written a simple external processor plugin, see source code here, following the instructions here.

The plugin is invoked with execd as follows:

[[processors.execd]]
command = ["/home/bali/geoip", "-config", "/home/bali/plugin.conf"]

And the problem is that the contents of the specified configuration file are read but not applied to the plugin.

I have also found out that it works properly in case the external processor plugin is a StreamingProcessor instead of a standard Processor, therefore the problem appears to be when a Processor is converted to a StreamingProcessor, the configuration settings are not applied.

@a-bali a-bali added the bug unexpected problem or unintended behavior label Oct 15, 2020
@ssoroka
Copy link
Contributor

ssoroka commented Oct 15, 2020

ah, yes, I think you're on to something there. I'll check out your example code and figure out what's going on.

@ssoroka ssoroka added the area/execd Issues related to execd or plugins that would be better suited to be used through execd label Oct 15, 2020
@ssoroka
Copy link
Contributor

ssoroka commented Oct 15, 2020

Thanks for the detailed bug report. That made it easy to track down. It's patched now, and will be in the nightly release tomorrow, and will be in 1.16.0-rc2 and 1.15.4 when they come out.

a-bali added a commit to a-bali/telegraf-geoip that referenced this issue Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/execd Issues related to execd or plugins that would be better suited to be used through execd bug unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants