Skip to content

Commit

Permalink
chore: Adding influx's semantic commit and PR message checker, so we … (
Browse files Browse the repository at this point in the history 
#11009)

* chore: Adding influx's semantic commit and PR message checker, so we can deprecate semantic-pull-requests

* feat: change commit history for semantic validation to 1 (last commit)
  • Loading branch information
@tysonkamp
tysonkamp authored Apr 26, 2022
1 parent a6f278a commit c8aba00
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions .github/workflows/semantic.yml
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
---
name: "Semantic PR and Commit Messages"

on:
pull_request:
types: [opened, reopened, synchronize, edited]

jobs:
semantic:
uses: influxdata/validate-semantic-github-messages/.github/workflows/semantic.yml@main
# optional; 250 is default and max
with:
COMMITS_HISTORY: 1

This comment has been minimized.

Sign in to view

Copy link
@powersj

powersj Apr 26, 2022

Contributor

@tysonkamp - I must have missed this addition in the last PR. Can you confirm this config will ensure that only the last commit a user made is semantic?

I think what we are really after from the previous tool is checking the PR title. When reviewing PRs, All our merges happen in and through GitHub. As such the title is what is put in the commit message header and what we want to ensure is correct before proceeding.

Would you be open to adding a titleOnly option similar to what the previous tool had?

@sspaink @reimda would that meet our needs and allow us to move over?

This comment has been minimized.

Sign in to view

Copy link
@tysonkamp

tysonkamp Apr 26, 2022

Author Contributor

I'll endeavor to implement the following enhancements for telegraf:
If there is one commit, check only the commit message and not the PR title
If there is > 1 commit, check only the PR title

cc @jacobmarble

0 comments on commit c8aba00

Please sign in to comment.