Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle default value for pb2 enums without a 0 value #136

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: handle default value for pb2 enums without a 0 value #136

wants to merge 1 commit into from

Conversation

susnmos
Copy link

@susnmos susnmos commented Sep 12, 2024

  • Fixed the issue where pb2 enums might not have a 0 value.
  • Ensured that when a 0 value exists, pb2 defaults to the first enum value.
  • Updated pbjson-build to handle enum value conversion using prost field methods instead of try_from.
  • Resolved the serde::ser::Error::custom(format!("Invalid variant {{}}", {}))) error.

@MyBestFriend
fix: handle default value for pb2 enums without a 0 value
0aff9b2 
- Fixed the issue where pb2 enums might not have a 0 value.
- Ensured that when a 0 value exists, pb2 defaults to the first enum value.
- Updated pbjson-build to handle enum value conversion using prost field methods instead of try_from.
- Resolved the serde::ser::Error::custom(format!(\"Invalid variant {{}}\", {}))) error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@susnmos @MyBestFriend